Fix multi-byte UTF-8 split across chunk buffers in LineReader. - #237
Open
grrrrrrrrr wants to merge 1 commit into
Open
Fix multi-byte UTF-8 split across chunk buffers in LineReader.#237grrrrrrrrr wants to merge 1 commit into
LineReader.#237grrrrrrrrr wants to merge 1 commit into
Conversation
When a line spanned across multiple 8 KB buffer chunks, `read_line_lossy` converted each chunk to a `String` independently via `String::from_utf8_lossy`. If a multi-byte UTF-8 code point (e.g. 3-byte or 4-byte character) straddled the 8 KB chunk boundary, the partial bytes at the end of the first chunk and beginning of the next chunk were treated as invalid UTF-8 and replaced with `U+FFFD` (). This change buffers raw bytes across chunk refills for multi-chunk lines, applying `from_utf8_lossy` once to the complete line byte slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a line spanned across multiple 8 KB buffer chunks,
read_line_lossyconverted each chunk to aStringindependently viaString::from_utf8_lossy. If a multi-byte UTF-8 code point (e.g. 3-byteor 4-byte character) straddled the 8 KB chunk boundary, the partial bytes
at the end of the first chunk and beginning of the next chunk were
treated as invalid UTF-8 and replaced with
U+FFFD().This change buffers raw bytes across chunk refills for multi-chunk
lines, applying
from_utf8_lossyonce to the complete line byte slice.