Check for NULL ai_canonname in ospect::os::unix::fqdn. - #239
Open
grrrrrrrrr wants to merge 1 commit into
Open
Conversation
In `ospect::os::unix::fqdn`, `getaddrinfo` is invoked with the `AI_CANONNAME` flag. POSIX allows `getaddrinfo` to return 0 (success) while leaving `ai_canonname` as NULL if canonical name lookup fails or only numeric addresses are resolved. Calling `CStr::from_ptr` on a NULL pointer resulted in an immediate segmentation fault. This change verifies that `ai_canonname` is non-NULL before constructing the `CStr` and ensures `freeaddrinfo` is always called before returning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ospect::os::unix::fqdn,getaddrinfois invoked with theAI_CANONNAMEflag. POSIX allowsgetaddrinfoto return 0 (success)while leaving
ai_canonnameas NULL if canonical name lookup fails oronly numeric addresses are resolved. Calling
CStr::from_ptron a NULLpointer resulted in an immediate segmentation fault.
This change verifies that
ai_canonnameis non-NULL before constructingthe
CStrand ensuresfreeaddrinfois always called before returning.