Call EndEnumeration on normal completion in WMI QueryRows. - #243
Open
grrrrrrrrr wants to merge 1 commit into
Open
Call EndEnumeration on normal completion in WMI QueryRows.#243grrrrrrrrr wants to merge 1 commit into
EndEnumeration on normal completion in WMI QueryRows.#243grrrrrrrrr wants to merge 1 commit into
Conversation
In `wmi::QueryRows::next`, property iteration begins with `IWbemClassObject::BeginEnumeration` and iterates using `Next`. When `Next` returned `WBEM_S_NO_MORE_DATA`, the loop terminated without calling `EndEnumeration`. Microsoft WMI COM documentation specifies that `EndEnumeration` must be called to release internal enumeration resources before starting a new enumeration or releasing the object. This change adds the missing `EndEnumeration` call upon loop completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
wmi::QueryRows::next, property iteration begins withIWbemClassObject::BeginEnumerationand iterates usingNext. WhenNextreturnedWBEM_S_NO_MORE_DATA, the loop terminated withoutcalling
EndEnumeration.Microsoft WMI COM documentation specifies that
EndEnumerationmust becalled to release internal enumeration resources before starting a new
enumeration or releasing the object.
This change adds the missing
EndEnumerationcall upon loop completion.