Migrate explicit capture_by(this) annotations to new macro#389
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Migrate explicit capture_by(this) annotations to new macro#389copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This CL migrates remaining explicitly written [[clang::lifetime_capture_by(this)]] and ABSL_INTERNAL_ATTRIBUTE_CAPTURED_BY(this) annotations outside of absl to instead use ABSL_INTERNAL_ATTRIBUTE_CAPTURED_BY_THIS inline with the llvm migration. LLVM commit reference: llvm/llvm-project@a627e7e PiperOrigin-RevId: 950762270
copybara-service
Bot
force-pushed
the
test_950762270
branch
from
July 20, 2026 13:17
1db5d29 to
6a7f734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate explicit capture_by(this) annotations to new macro
This CL migrates remaining explicitly written [[clang::lifetime_capture_by(this)]] and ABSL_INTERNAL_ATTRIBUTE_CAPTURED_BY(this) annotations outside of absl to instead use ABSL_INTERNAL_ATTRIBUTE_CAPTURED_BY_THIS inline with the llvm migration.
LLVM commit reference: llvm/llvm-project@a627e7e