Skip to content

[ci] Make UI tests follow Cargo feature selection - #3562

Merged
joshlf merged 1 commit into
mainfrom
Gbev6nw7raszgypqdblfidkxigyoc5bsa
Aug 24, 2026
Merged

[ci] Make UI tests follow Cargo feature selection#3562
joshlf merged 1 commit into
mainfrom
Gbev6nw7raszgypqdblfidkxigyoc5bsa

Conversation

@joshlf

@joshlf joshlf commented Aug 19, 2026

Copy link
Copy Markdown
Member

Authored by Codex, posting via joshlf's account

Declare UI and codegen eligibility in Cargo.toml so ordinary cargo test can select the right integration targets without workflow filters.

Capture the exact outer feature arguments, replay them for nested UI artifact builds, and derive fixture cfgs from Cargo's resolved feature set. Limit expensive UI execution to canonical toolchains and normalize rustc's unstable candidate-count summary.

Tests: canonical expected-output regeneration; cargo-zerocopy unit tests; testutil tests on stable and MSRV; root UI on stable/nightly/all-features; unsupported-toolchain UI ignore.


Latest Update: v18 — Compare vs v17

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v18 v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gbev6nw7raszgypqdblfidkxigyoc5bsa && git checkout -b pr-Gbev6nw7raszgypqdblfidkxigyoc5bsa FETCH_HEAD

Checkout

git fetch origin refs/heads/Gbev6nw7raszgypqdblfidkxigyoc5bsa && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gbev6nw7raszgypqdblfidkxigyoc5bsa && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gbev6nw7raszgypqdblfidkxigyoc5bsa

Stacked PRs enabled by GHerrit.

@codecov-commenter

codecov-commenter commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (ee9216f) to head (d8c1405).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3562   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6093     6093           
=======================================
  Hits         5597     5597           
  Misses        496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread zerocopy/Cargo.toml Outdated
*Authored by Codex, posting via joshlf's account*

Declare UI and codegen eligibility in Cargo.toml so ordinary cargo test can select the right integration targets without workflow filters.

Capture the exact outer feature arguments, replay them for nested UI artifact builds, and derive fixture cfgs from Cargo's resolved feature set. Limit expensive UI execution to canonical toolchains and normalize rustc's unstable candidate-count summary.

gherrit-pr-id: Gbev6nw7raszgypqdblfidkxigyoc5bsa
Tests: canonical expected-output regeneration; cargo-zerocopy unit tests; testutil tests on stable and MSRV; root UI on stable/nightly/all-features; unsupported-toolchain UI ignore.
@joshlf
joshlf force-pushed the Gbev6nw7raszgypqdblfidkxigyoc5bsa branch from 4b55cba to d8c1405 Compare August 21, 2026 08:44
@joshlf

joshlf commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

Authored by Codex, posting via joshlf's account

Addressed in v18: the Cargo comment now states plainly that the UI integration
test needs derive and that Cargo skips it when that feature is disabled.

@codex review

Please review exact head d8c1405f5f7bc123ba1111f80aa3ace719bc68cb and report
any remaining actionable issue.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: d8c1405f5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshlf
joshlf added this pull request to the merge queue Aug 24, 2026
Merged via the queue into main with commit cf8cd0b Aug 24, 2026
128 checks passed
@joshlf
joshlf deleted the Gbev6nw7raszgypqdblfidkxigyoc5bsa branch August 24, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants