feat(storage): add support for bucket metadata call in async client#16262
feat(storage): add support for bucket metadata call in async client#16262bajajneha27 wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements the asynchronous GetBucket API across the Google Cloud Storage C++ SDK, including client interfaces, connection implementations, decorators, stubs, mocks, and tests. A review of the changes identified an issue in the integration tests where BucketName is constructed with an already-prefixed string, which would result in a double-prefixed bucket name.
|
|
||
| auto bucket = | ||
| async | ||
| .GetBucket(BucketName("projects/_/buckets/" + MakeRandomObjectName())) |
There was a problem hiding this comment.
The BucketName constructor expects the simple bucket name (e.g., my-bucket), and its FullName() method automatically prepends the projects/_/buckets/ prefix. Passing a string that already contains the prefix will result in a double-prefixed name like projects/_/buckets/projects/_/buckets/.... You should pass only the random name to BucketName.
.GetBucket(BucketName(MakeRandomObjectName()))
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16262 +/- ##
==========================================
- Coverage 92.27% 92.26% -0.01%
==========================================
Files 2214 2214
Lines 206505 206645 +140
==========================================
+ Hits 190549 190669 +120
- Misses 15956 15976 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d6a54d9 to
aff7403
Compare
No description provided.