Skip to content

feat: add Otel Tracing helpers and tests - #9070

Open
shivanee-p wants to merge 5 commits into
shivaneep-o11y-client-optionsfrom
shivaneep-o11y-tracer-helper
Open

feat: add Otel Tracing helpers and tests#9070
shivanee-p wants to merge 5 commits into
shivaneep-o11y-client-optionsfrom
shivaneep-o11y-tracer-helper

Conversation

@shivanee-p

@shivanee-p shivanee-p commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Introduces OpenTelemetry tracing helpers, trace context definitions, and a test harness in google-gax to support API call tracing across Google Cloud Node.js client libraries.

  • Added @opentelemetry/api to dependencies.
  • Wraps API call attempts in active spans, populates static and dynamic GCP trace attributes, and records exceptions and error metadata
  • Defined DynamicTraceContext and StaticTraceContext
  • Implemented @opentelemetry/api interfaces for unit testing
  • Added unit tests verifying span creation, attribute population, error recording, and transport handling (grpc and http).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new helper file TracerHelper.ts to support observability tracing, defining context interfaces and helper functions. The review feedback points out a syntax error where backticks are used instead of single quotes for an import statement, as well as an unused import dependency.

Comment thread core/packages/gax/src/observability/TracerHelper.ts Outdated
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-tracer-helper branch from 200ed4b to a70e4f5 Compare August 4, 2026 01:55
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-tracer-helper branch from a70e4f5 to 2bd856a Compare August 4, 2026 03:30
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-tracer-helper branch from 2bd856a to dc03a0f Compare August 14, 2026 20:55
Base automatically changed from shivaneep-o11y-flag to main August 15, 2026 00:35
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-tracer-helper branch 4 times, most recently from 1ba8104 to 4b2e518 Compare August 19, 2026 23:47
@shivanee-p
shivanee-p changed the base branch from main to shivaneep-o11y-client-options August 19, 2026 23:49
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-tracer-helper branch from 4b2e518 to 7f55830 Compare August 19, 2026 23:53
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-tracer-helper branch from 7f55830 to b63ecf8 Compare August 19, 2026 23:56
@shivanee-p shivanee-p changed the title Shivaneep o11y tracer helper feat: add Otel Tracing helpers and tests Aug 19, 2026
@shivanee-p
shivanee-p marked this pull request as ready for review August 20, 2026 00:08
@shivanee-p
shivanee-p requested a review from a team as a code owner August 20, 2026 00:08
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-tracer-helper branch from d290c39 to c4c4c5f Compare August 20, 2026 19:36
@github-actions
github-actions Bot requested a review from westarle August 20, 2026 19:36
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-tracer-helper branch 2 times, most recently from 36f1f13 to 7871ea1 Compare August 20, 2026 22:53
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-tracer-helper branch from 7871ea1 to f5c6b35 Compare August 21, 2026 18:46
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-tracer-helper branch from f5c6b35 to 46a6647 Compare August 21, 2026 19:26
@shivanee-p
shivanee-p force-pushed the shivaneep-o11y-tracer-helper branch from 46a6647 to c537e56 Compare August 21, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant