Skip to content

chore(storage): factor out context type to fix jsdoc processing failure - #9173

Open
feywind wants to merge 4 commits into
googleapis:mainfrom
feywind:storage-jsdoc-fixes
Open

chore(storage): factor out context type to fix jsdoc processing failure#9173
feywind wants to merge 4 commits into
googleapis:mainfrom
feywind:storage-jsdoc-fixes

Conversation

@feywind

@feywind feywind commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Newer jsdoc/tsdoc complains about the indexed types, so this factors those out to get the docs jobs going again. This also removes the sample test scripts since the handwritten samples were removed a while back.

@product-auto-label product-auto-label Bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Aug 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes sample integration tests and their associated @example JSDoc annotations across various source files. Additionally, it extracts the inline contexts type from FileMetadata into a dedicated Contexts interface, exports it from the main entry point, and updates utility validation functions to use this new interface. There are no review comments, so I have no feedback to provide.

@feywind
feywind marked this pull request as ready for review August 19, 2026 22:09
@feywind
feywind requested a review from a team as a code owner August 19, 2026 22:09
@feywind feywind changed the title chore(storage): decommission removed sample test suite; factor out context type to fix jsdoc processing chore(storage): factor out context type to fix jsdoc processing failure Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants