feat(gax): accept clientOptions in createApiCall for telemetry tracing - #9176
Open
shivanee-p wants to merge 1 commit into
Open
feat(gax): accept clientOptions in createApiCall for telemetry tracing#9176shivanee-p wants to merge 1 commit into
shivanee-p wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces telemetry tracing options to ClientOptions and integrates them into createApiCall to determine if tracing is enabled. Key feedback includes explicitly checking if the GOOGLE_SDK_NODE_EXPERIMENTAL_O11Y_ENABLED environment variable equals 'true' to avoid false positives with other string values. Additionally, the console.log statements used for debugging tracing status should be removed to prevent polluting the standard output of consuming applications, and the corresponding unit tests that spy on these logs should be cleaned up.
shivanee-p
force-pushed
the
shivaneep-o11y-client-options
branch
2 times, most recently
from
August 19, 2026 23:56
f45d91d to
ae7b3a3
Compare
shivanee-p
marked this pull request as ready for review
August 19, 2026 23:57
westarle
requested changes
Aug 20, 2026
westarle
left a comment
Contributor
There was a problem hiding this comment.
I think we should consider CallSettings carefully. I would take the change to
shivanee-p
force-pushed
the
shivaneep-o11y-client-options
branch
2 times, most recently
from
August 20, 2026 22:46
cef268a to
39ae92a
Compare
shivanee-p
force-pushed
the
shivaneep-o11y-client-options
branch
2 times, most recently
from
August 21, 2026 18:46
db0e16d to
1858ae8
Compare
shivanee-p
force-pushed
the
shivaneep-o11y-client-options
branch
from
August 21, 2026 21:34
a6454bc to
8baf444
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds clientOptions support and telemetry gating logic to createApiCall in google-gax to support OpenTelemetry tracing.