Skip to content

feat(gax): allow Google API client header to be overrided - #6665

Open
alvarowolfx wants to merge 7 commits into
googleapis:mainfrom
alvarowolfx:feat-gax-override-api-header
Open

feat(gax): allow Google API client header to be overrided#6665
alvarowolfx wants to merge 7 commits into
googleapis:mainfrom
alvarowolfx:feat-gax-override-api-header

Conversation

@alvarowolfx

Copy link
Copy Markdown
Contributor

This will allow veneers to change header from GAPIC to veneer (gccl).

Towards #2138

@alvarowolfx

alvarowolfx commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

need to be done in sync with googleapis/librarian#7514 removed template changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the resolution and handling of the x-goog-api-client header across multiple generated transport modules. It introduces helper functions to resolve these headers for both gRPC and REST requests, improves code cleanliness by removing redundant #[allow(unused_imports)] attributes, and updates the ReqwestClient to support these changes. I have no feedback to provide.

Comment thread src/gax-internal/src/http.rs Outdated
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.67%. Comparing base (bec0ff2) to head (3315904).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6665      +/-   ##
==========================================
- Coverage   96.67%   96.67%   -0.01%     
==========================================
  Files         308      308              
  Lines       97938    97988      +50     
==========================================
+ Hits        94683    94728      +45     
- Misses       3255     3260       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alvarowolfx

Copy link
Copy Markdown
Contributor Author

/gcbrun

@alvarowolfx
alvarowolfx marked this pull request as ready for review September 8, 2026 20:27
@alvarowolfx
alvarowolfx requested a review from a team as a code owner September 8, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants