fix(gax): panic in LimitedAttemptCount - #6725
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the on_throttle method in LimitedAttemptCount to handle cases where the inner policy continues but the maximum attempt count has been reached, returning ThrottleResult::Exhausted instead of asserting. It also adds a corresponding unit test. The review feedback suggests simplifying the nested match and conditional logic using a match guard to improve readability and adhere to the style guide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6725 +/- ##
=======================================
Coverage 96.66% 96.67%
=======================================
Files 308 308
Lines 97778 97801 +23
=======================================
+ Hits 94519 94546 +27
+ Misses 3259 3255 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
coryan
marked this pull request as ready for review
September 7, 2026 18:04
dbolduc
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6677