Repository navigation
refactor: separate model loading and execution contexts - #33
Open
zhangzhenghao wants to merge 1 commit into
Open
zhangzhenghao wants to merge 1 commit into
zhangzhenghao wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor all six model architectures following llama.cpp's separation of architecture loading and architecture-specific execution (reference: ggml-org/llama.cpp at caa8191df159f764fb0160e3d2fc6be008948aee).
This is an execution-organization refactor of the existing eager TensorOps runtime, not a conversion to a persistent whole-model GGML graph.
Validation
4204cd39b45a066869fbebfafbc39b4b1d502fd1; no blocking findings.519a84e3b6dafe1534ecf93693f96855712adcfb):muq_mulan_model_parityexpects an obsolete--audio-featuresCLI error string; its early exit prevents F16 fixture generation, causingmuq_mulan_oracle_pipelineto fail on the missing fixture.git diff --checkpassed.Remote CI
Verified on head
1e6f4d1284ede148e5c2442b2c649426023a4b99: 8/9 checks passed.40396825113.40396825231.ffmpeg-N-127043-g5a54fcf75e-winarm64-gpl/bin/ffmpeg.execrashes converting mono.wav to mono.flac with exit status3221225477. This is not a model-source compiler/test failure.519a84e3b6dafe1534ecf93693f96855712adcfb, CI run40102240289(job120896596496). Workflow, fixture generator, and root CMake files are unchanged by this PR. The Windows ARM64 failure is an existing dependency issue, not introduced by this refactor.