Repository navigation
Wait for repository description before requesting neighbors - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GitHub renders the repository sidebar before its About description, the extension requests neighbors with an empty description and marks initialization complete. It never retries when the description appears, so repositories such as
gorse-io/xveccan display “No similar repositories found” even though description search returns results.Wait until the React About description contains text before requesting neighbors. Treat GitHub's no-description placeholder or website-only About content as a completed render without a description. Observe text-node updates as well as inserted elements, and retain the loaded description for pagination. Navigation resets the waiting state. Bump the Chrome and Firefox extension manifests to version
0.11.Validation:
node --check extension/content.jsandgit diff --checkpassed; both extension manifests parse as JSON and declare version0.11.