Skip to content

Point README-PYPI.md at the repo-hosted logo (PyPI renders this file, #124 covered README.md only) - #123

Open
wyatt-shippo wants to merge 1 commit into
mainfrom
SARCH-602-readme-logo-url
Open

wyatt-shippo wants to merge 1 commit into
mainfrom
SARCH-602-readme-logo-url

Conversation

@wyatt-shippo

@wyatt-shippo wyatt-shippo commented Oct 27, 2026 •

Copy link
Copy Markdown

#124 fixed README.md by hosting the logo in .github/assets and is merged. README-PYPI.md is what pyproject.toml names as the package readme, so PyPI renders that file, and it still pointed at https://docs.goshippo.com/images/Logo.png, which returns 404. This points both occurrences at the same repo-hosted asset as README.md.

Jira: https://shippo.atlassian.net/browse/SARCH-602

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor
Tests Skipped Failures Errors Time
17 0 💤 0 ❌ 0 🔥 18.991 ⏱

… this file)

#124 fixed README.md by hosting the logo in .github/assets, but README-PYPI.md,
which pyproject names as the package readme, still pointed at the dead
docs.goshippo.com/images/Logo.png. Use the same repo-hosted asset.
@wyatt-shippo
wyatt-shippo force-pushed the SARCH-602-readme-logo-url branch from 78621bb to cbbd962 Compare October 28, 2026 13:36
@wyatt-shippo wyatt-shippo changed the title Fix README logo URL: /images/Logo.png returns 404, published file is /images/logo.png Point README-PYPI.md at the repo-hosted logo (PyPI renders this file, #124 covered README.md only) Oct 28, 2026
@wyatt-shippo
wyatt-shippo marked this pull request as ready for review October 28, 2026 13:39
@wyatt-shippo
wyatt-shippo requested review from a team as code owners October 28, 2026 13:39

@jfriedr jfriedr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants