Repository navigation
Point README-PYPI.md at the repo-hosted logo (PyPI renders this file, #124 covered README.md only) - #123
Open
wyatt-shippo wants to merge 1 commit into
Open
Point README-PYPI.md at the repo-hosted logo (PyPI renders this file, #124 covered README.md only)#123wyatt-shippo wants to merge 1 commit into
wyatt-shippo wants to merge 1 commit into
Conversation
Contributor
|
… this file) #124 fixed README.md by hosting the logo in .github/assets, but README-PYPI.md, which pyproject names as the package readme, still pointed at the dead docs.goshippo.com/images/Logo.png. Use the same repo-hosted asset.
wyatt-shippo
force-pushed
the
SARCH-602-readme-logo-url
branch
from
October 28, 2026 13:36
78621bb to
cbbd962
Compare
wyatt-shippo
marked this pull request as ready for review
October 28, 2026 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#124 fixed README.md by hosting the logo in
.github/assetsand is merged.README-PYPI.mdis whatpyproject.tomlnames as the package readme, so PyPI renders that file, and it still pointed athttps://docs.goshippo.com/images/Logo.png, which returns 404. This points both occurrences at the same repo-hosted asset as README.md.Jira: https://shippo.atlassian.net/browse/SARCH-602