Skip to content

fix(ci): provision weekly receipt authority per job - #223

Merged
metaphorics merged 1 commit into
stabilize/test262-fixture-deadlinesfrom
stabilize/audit-authority-bootstrap
Sep 21, 2026
Merged

metaphorics merged 1 commit into
stabilize/test262-fixture-deadlinesfrom
stabilize/audit-authority-bootstrap

Conversation

@metaphorics

Copy link
Copy Markdown
Collaborator

Change

Materialize the locked TypeScript compiler and test authorities in both the weekly shard job and its independent accounting job before receipt execution. Use the same source-fetch commands already present in PR CI and nightly CI.

Add a typed YAML regression test that checks prerequisites inside each compiler receipt job, in execution order. A fetch in a sibling job cannot satisfy it.

Validation

  • RED: the new regression failed on weekly-audit.yml:accounting missing typescript-7-compiler.
  • GREEN: all 5 workflow receipt integration tests passed.
  • cargo fmt --all --check: passed.
  • cargo clippy --locked -p bamts-verification --test workflow_receipts -- -D warnings: passed.
  • git diff --check: passed.
  • Manual diff review: limited to authority provisioning and its regression test.

Evidence and scope

Weekly run 35502333780, job 106056749055 failed with E_TOOL_MISSING for target/authority/typescript-7.0.2/.bamti-source.json. No authority, digest, classification, or completeness check is disabled.

Known residuals

The separate nightly x64 merge rejects different harness_digest values across shards. Downloaded shard 1 and 2 receipts have matching authority, source-tree and candidate-binary digests but different harness digests. That requires canonical harness artifact reuse, not weaker receipt equality. This PR fixes missing prerequisites, not complete weekly audit closure.

Stack

Depends on #222.

Post-Deploy Monitoring & Validation

On the next weekly run, maintainers should verify both authority fetch steps succeed in every shard and accounting job. E_TOOL_MISSING for either authority is a regression. Receipt digest and set-mismatch failures remain blocking and must be investigated rather than bypassed.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d9d43eea-cae3-4294-9df6-b9aaeb8fa21e

📥 Commits

Reviewing files that changed from the base of the PR and between 0e4129c and 5d40345.

📒 Files selected for processing (2)
  • .github/workflows/weekly-audit.yml
  • crates/bamts-verification/tests/workflow_receipts.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-20T12:37:25.065500Z 5d40345 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR correctly fixes the E_TOOL_MISSING error by provisioning TypeScript compiler and test authorities in both the weekly shard and accounting jobs before receipt execution. The regression test appropriately validates that all compiler receipt jobs in ci.yml, nightly.yml, and weekly-audit.yml provision required authorities before execution.

The implementation is consistent with existing patterns in PR CI and nightly CI workflows, and the test coverage ensures the fix remains stable across all affected workflows. No blocking issues identified.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@metaphorics
metaphorics added this pull request to stack #227 September 20, 2026 21:26
@metaphorics
metaphorics added this pull request to the merge queue Sep 21, 2026
Merged via the queue into main with commit 177d09b Sep 21, 2026
11 of 16 checks passed
@metaphorics
metaphorics deleted the stabilize/audit-authority-bootstrap branch September 21, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant