fix(ci): provision weekly receipt authority per job - #223
metaphorics merged 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
This PR correctly fixes the E_TOOL_MISSING error by provisioning TypeScript compiler and test authorities in both the weekly shard and accounting jobs before receipt execution. The regression test appropriately validates that all compiler receipt jobs in ci.yml, nightly.yml, and weekly-audit.yml provision required authorities before execution.
The implementation is consistent with existing patterns in PR CI and nightly CI workflows, and the test coverage ensures the fix remains stable across all affected workflows. No blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Change
Materialize the locked TypeScript compiler and test authorities in both the weekly shard job and its independent accounting job before receipt execution. Use the same source-fetch commands already present in PR CI and nightly CI.
Add a typed YAML regression test that checks prerequisites inside each compiler receipt job, in execution order. A fetch in a sibling job cannot satisfy it.
Validation
Evidence and scope
Weekly run 35502333780, job 106056749055 failed with E_TOOL_MISSING for target/authority/typescript-7.0.2/.bamti-source.json. No authority, digest, classification, or completeness check is disabled.
Known residuals
The separate nightly x64 merge rejects different harness_digest values across shards. Downloaded shard 1 and 2 receipts have matching authority, source-tree and candidate-binary digests but different harness digests. That requires canonical harness artifact reuse, not weaker receipt equality. This PR fixes missing prerequisites, not complete weekly audit closure.
Stack
Depends on #222.
Post-Deploy Monitoring & Validation
On the next weekly run, maintainers should verify both authority fetch steps succeed in every shard and accounting job. E_TOOL_MISSING for either authority is a regression. Receipt digest and set-mismatch failures remain blocking and must be investigated rather than bypassed.