Skip to content

Add multiple branch exit pages - #3010

Open
thomasiles wants to merge 4 commits into
mainfrom
add-multiple-branch-exit-pages
Open

Add multiple branch exit pages#3010
thomasiles wants to merge 4 commits into
mainfrom
add-multiple-branch-exit-pages

Conversation

@thomasiles

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/gecvdskV/3173-change-add-edit-delete-exit-page-to-work-with-multiple-branches

This PR adds a new exit page controller, input object and view to add exit pages under the multiple branches flag.

Currently there are no guards to adding exit pages to pages. I think we probably want to prevent exit pages based on the question type. I think we can add that later though. It also doesn't add update and delete which I'll do in other PRs.

There is no link from the new routes page (or anywhere else). To check the new page use the URL directly, for example:
http://localhost:3000/forms/6/pages/23/exit-pages/new

image
  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3010.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@thomasiles
thomasiles marked this pull request as ready for review August 6, 2026 16:16
@hannahkc

hannahkc commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

content looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants