Add multiple branch exit pages - #3010
Open
thomasiles wants to merge 4 commits into
Open
Conversation
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3010.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
thomasiles
marked this pull request as ready for review
August 6, 2026 16:16
Contributor
|
content looks good to me |
SamJamCul
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/gecvdskV/3173-change-add-edit-delete-exit-page-to-work-with-multiple-branches
This PR adds a new exit page controller, input object and view to add exit pages under the multiple branches flag.
Currently there are no guards to adding exit pages to pages. I think we probably want to prevent exit pages based on the question type. I think we can add that later though. It also doesn't add update and delete which I'll do in other PRs.
There is no link from the new routes page (or anywhere else). To check the new page use the URL directly, for example:
http://localhost:3000/forms/6/pages/23/exit-pages/new