Skip to content

Use SES to send all confirmation emails - #2164

Open
alice-carr wants to merge 1 commit into
mainfrom
use-ses-to-send-all-confirmation-emails
Open

Use SES to send all confirmation emails#2164
alice-carr wants to merge 1 commit into
mainfrom
use-ses-to-send-all-confirmation-emails

Conversation

@alice-carr

@alice-carr alice-carr commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/GfBTJbNL/3154-blocked-until-a-sprint-after-copy-of-answers-launch-use-ses-to-send-all-confirmation-emails

We currently use SES to send confirmation emails that include a copy of the user’s answers and Notify to send confirmation emails that do not. We should switch all confirmation emails to use SES.

This must be merged alongside the e2e pr: govuk-forms/forms-e2e-tests#324

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@alice-carr
alice-carr force-pushed the use-ses-to-send-all-confirmation-emails branch 2 times, most recently from ab29a85 to aa74833 Compare June 22, 2026 11:17
@alice-carr
alice-carr force-pushed the use-ses-to-send-all-confirmation-emails branch 6 times, most recently from b403299 to 10f3022 Compare July 6, 2026 14:44
@alice-carr
alice-carr force-pushed the use-ses-to-send-all-confirmation-emails branch from 10f3022 to 4fccc8f Compare July 21, 2026 09:57
@alice-carr
alice-carr force-pushed the use-ses-to-send-all-confirmation-emails branch from 4fccc8f to a1e0225 Compare August 4, 2026 09:01
@alice-carr alice-carr changed the title wip: Use SES to send all confirmation emails Use SES to send all confirmation emails Aug 4, 2026
@alice-carr
alice-carr force-pushed the use-ses-to-send-all-confirmation-emails branch from a1e0225 to 394b32f Compare August 4, 2026 14:23
@alice-carr
alice-carr marked this pull request as ready for review August 4, 2026 14:28
@alice-carr alice-carr changed the title Use SES to send all confirmation emails WIP: Use SES to send all confirmation emails Aug 4, 2026
@alice-carr
alice-carr marked this pull request as draft August 4, 2026 14:49
Comment thread app/jobs/send_confirmation_email_job.rb Outdated
@alice-carr
alice-carr force-pushed the use-ses-to-send-all-confirmation-emails branch 5 times, most recently from ab939ec to 1f5946e Compare August 10, 2026 10:37
we currently use SES to send confirmation emails that include a copy of the user's answers, and notify to send the confirmation emails that don't.
This commit changes this so that all confirmation emails are sent with SES. it also updates the tests to support this.
@alice-carr
alice-carr force-pushed the use-ses-to-send-all-confirmation-emails branch from 1f5946e to eeadfa8 Compare August 10, 2026 10:46
@alice-carr alice-carr changed the title WIP: Use SES to send all confirmation emails Use SES to send all confirmation emails Aug 10, 2026
@alice-carr
alice-carr marked this pull request as ready for review August 10, 2026 10:50
@github-actions

Copy link
Copy Markdown
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants