Skip to content

add reportId when recreating network - #1054

Merged
EtienneLt merged 3 commits into
mainfrom
add-reportuuid-when-recreate-network
Aug 13, 2026
Merged

add reportId when recreating network#1054
EtienneLt merged 3 commits into
mainfrom
add-reportuuid-when-recreate-network

Conversation

@EtienneLt

Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 92674baf-c50d-4481-9fe0-a38da57eebba

📥 Commits

Reviewing files that changed from the base of the PR and between 32fd6ce and 689e468.

📒 Files selected for processing (1)
  • src/main/java/org/gridsuite/study/server/service/StudyService.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/main/java/org/gridsuite/study/server/service/StudyService.java

📝 Walkthrough

Walkthrough

Changes

StudyService now passes report UUIDs explicitly during network creation and recreation. New operations generate UUIDs. Recreation from an existing root network reuses its stored report UUID. persistNetwork forwards the UUID to networkConversionService.

Network report UUID propagation

Layer / File(s) Summary
Report ID persistence contract
src/main/java/org/gridsuite/study/server/service/StudyService.java
Study creation, root-network creation, and root-network case modification generate report UUIDs. persistNetwork forwards each supplied UUID to networkConversionService.
Recreation report propagation
src/main/java/org/gridsuite/study/server/service/StudyService.java
Case-based recreation generates a report UUID. Existing-root-network recreation forwards its stored report UUID through the internal recreation flow.

Mergeability Score: ⚪ Minimal · up to 689e4

This localized change has no actionable merge-blocking risk identified at the current head and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 22.22% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description contains only a generic template and does not provide meaningful details about the changeset. Add a concise summary that explains how reportId is passed during network recreation and how report UUIDs are generated or reused.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary change: adding reportId when recreating a network.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread src/main/java/org/gridsuite/study/server/service/StudyService.java Outdated
Comment thread src/main/java/org/gridsuite/study/server/service/StudyService.java Outdated
Comment thread src/main/java/org/gridsuite/study/server/service/StudyService.java Outdated
Slimane AMAR and others added 2 commits August 13, 2026 14:37
…into add-reportuuid-when-recreate-network
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@sonarqubecloud

Copy link
Copy Markdown

@EtienneLt
EtienneLt merged commit 8d97fae into main Aug 13, 2026
5 checks passed
@EtienneLt
EtienneLt deleted the add-reportuuid-when-recreate-network branch August 13, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants