Repository navigation
chore: Update check-node-versions.mjs to check Production.dockerfile - #16824
Merged
Merged
Conversation
The `check-node-versions.mjs` script is used to check a consistent version of Node is used across the various parts of the project. Add `Production.dockerfile` to be exhaustive.
akash1810
added
the
maintenance
akash1810
commented
Sep 30, 2026
| /** @type {const} @satisfies {ReadonlyArray<{filepath: string, pattern: RegExp, matchLevel: MatchLevel}>}*/ ([ | ||
| { | ||
| filepath: '../Production.dockerfile', | ||
| pattern: /^FROM dhi\.io\/node:(\d+)/m, |
Member
Author
There was a problem hiding this comment.
This regex was created offered by copilot - #16821 (comment).
akash1810
enabled auto-merge
September 30, 2026 15:47
arelra
approved these changes
Oct 2, 2026
|
Seen on PROD (merged by @akash1810 10 minutes and 13 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The
check-node-versions.mjsscript is used to check a consistent version of Node is used across the various parts of the project. AddProduction.dockerfileto be exhaustive.How has this change been tested?
I've run
./scripts/check-node-versions.mjslocally and it gave the desired output:I then updated
Production.dockerfileto use Node 26 and correctly got the following output: