Repository navigation
Conversation
We currently have `targetGroupWeights` configured for tag-page-rendering even though since #16965 the EC2 infrastructure has been removed. This change moves `targetGroupWeights` out of `ecsProps` so that it can be optionally set. NOTE: The GuCDK library will throw if: - EC2 props and ECS props are provided, but no weighting is provided - Weighting configures traffic to be routed to a target group scaled to 0
akash1810
added
the
maintenance
arelra
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
We currently have
targetGroupWeightsconfigured for tag-page-rendering even though since #16965 the EC2 infrastructure has been removed. This change movestargetGroupWeightsout ofecsPropsso that it can be optionally set, and therefore remove the weight configuration from tag-page-rendering.Note, the GuCDK library will throw if:
That is, I don't think we need to add any tests here.
Why?
Terser, more readable, code.
How has this change been tested?
CI passing should suffice; this change is a no-op as demonstrated by the CDK snapshots remaining unchanged.