Repository navigation
Puzzles archive menu: match design styling and keep it inside the viewport - #17019
Merged
Merged
Conversation
Narrow the menu and reduce item height, with updated padding, typography and default text colour. Add responsive Storybook stories for closed, open and long-title states.
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:d0d45f1d50402c67b421842226371709fec280826411e96ebe5d12ef7bc9cc88"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-afs-fix-puzzle-archive-dropdown"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32903"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGEFrom guardian/actions-ecr. |
DanielCliftonGuardian
approved these changes
Oct 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 23, 2026
|
Seen on PROD (merged by @andresilva-guardian 5 minutes and 6 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the Puzzles archive dropdown (
PuzzlesArchiveMenu) so it matches the design and stays fully visible on small screens:12px 16pxpadding,textSans15text with a 19.5px line height and black text. The menu is 209px wide (previously 256px). Separators, border and background are unchanged.right: 0) and ends 20px from the right edge of the viewport. Previously it opened to the right and overflowed the screen. The section inset is 10px belowmobileMediumand 20px from it, so the menu usesright: 10pxbelowmobileMediumto keep the 20px.data-placement="top"). The check runs when the menu opens, using the label's position and the menu height. When it fits neither above nor below, it uses the side with more room.PuzzlesArchiveMenu.island.stories.tsxwithClosed,Open,OpenWithLongTitlesandOpenUpwardsstories, rendered at 320px,mobileLandscape,tabletanddesktop, so Chromatic covers the open menu.Why?
How has this change been tested?
12px 16pxpadding and 15px text, and the menu is 209px wide.PuzzlesDirectoryunit tests, type check and Prettier pass.Screenshots