Repository navigation
Update the portrait immersive layout to match designs - #17020
Open
joshuaguardian wants to merge 1 commit into
Open
joshuaguardian wants to merge 1 commit into
joshuaguardian wants to merge 1 commit into
Conversation
github-actions
Bot
removed
the
run_chromatic
joshuaguardian
added
run_chromatic
github-actions
Bot
removed
the
run_chromatic
frederickobrien
left a comment
frederickobrien
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, though would value @JamieB-gu's two cents on the changes made to grid.ts as that powers a lot of layout stuff these days
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Update the portrait immersive layout to match designs
Why?
How has this change been tested?
Storybook and manually
Screenshots