Repository navigation
Align puzzles archive page title and game title typography with design - #17021
Merged
Merged
Conversation
Apply headlineBold28 styling to puzzle archive headings at the tablet breakpoint and above.
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:c031b42cc01d2ff87c770932950b93f3029caa4c8ad2265442b524d0f890c64c"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-afs-fix-puzzles-archive-title"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32910"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGEFrom guardian/actions-ecr. |
andresilva-guardian
marked this pull request as ready for review
October 23, 2026 16:14
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
DanielCliftonGuardian
approved these changes
Oct 23, 2026
|
Seen on PROD (merged by @andresilva-guardian 5 minutes and 6 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the heading typography on the puzzles archive page to match the design:
h1,PuzzlesArchiveLayout):headline.bld.24below 740px andheadline.bld.28from 740px (tablet) up. It washeadline.bld.34at every breakpoint.h2,PuzzlesArchiveCalendar):headline.med.28below 740px andheadline.med.34from 740px (tablet) up. It washeadline.bld.34at every breakpoint, with aline-height: 1.05override that is now removed so the token's 1.15 applies.Only existing
@guardian/source/foundationstokens are used (headlineBold24,headlineBold28,headlineMedium28,headlineMedium34), so there are no shared library changes.Why?
Design QA tickets on the archive page:
The tablet values for the game title were not specified in the design, so they follow the desktop value, the same pattern as the page title.
How has this change been tested?
Layouts/Puzzles Archive)Screenshots