Skip to content

Align puzzles archive page title and game title typography with design - #17021

Merged
andresilva-guardian merged 3 commits into
mainfrom
afs/fix/puzzles-archive-title
Oct 23, 2026
Merged

andresilva-guardian merged 3 commits into
mainfrom
afs/fix/puzzles-archive-title

Conversation

@andresilva-guardian

@andresilva-guardian andresilva-guardian commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

What does this change?

Updates the heading typography on the puzzles archive page to match the design:

  • Page title (h1, PuzzlesArchiveLayout): headline.bld.24 below 740px and headline.bld.28 from 740px (tablet) up. It was headline.bld.34 at every breakpoint.
  • Game title (h2, PuzzlesArchiveCalendar): headline.med.28 below 740px and headline.med.34 from 740px (tablet) up. It was headline.bld.34 at every breakpoint, with a line-height: 1.05 override that is now removed so the token's 1.15 applies.

Only existing @guardian/source/foundations tokens are used (headlineBold24, headlineBold28, headlineMedium28, headlineMedium34), so there are no shared library changes.

Why?

Design QA tickets on the archive page:

  • Title of page should be 28px, not 32px (tablet to wide)
  • Title of page should be 24px, not 32px (mobile to phablet)
  • Game title font size should be headline.med.34, currently headline.bld.34 (tablet to wide)
  • Game title font size should be headline.med.28, currently headline.bld.34 (mobile to phablet)

The tablet values for the game title were not specified in the design, so they follow the desktop value, the same pattern as the page title.

How has this change been tested?

  • Type check, Prettier and ESLint pass on the changed files.
  • Checked the archive layout in Storybook (Layouts/Puzzles Archive)

Screenshots

Before After
Screenshot 2026-10-23 at 17 20 37 Screenshot 2026-10-23 at 17 20 48

@github-actions

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:c031b42cc01d2ff87c770932950b93f3029caa4c8ad2265442b524d0f890c64c

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:c031b42cc01d2ff87c770932950b93f3029caa4c8ad2265442b524d0f890c64c"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-afs-fix-puzzles-archive-title"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32910"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-ecr.

@andresilva-guardian andresilva-guardian changed the title Afs/fix/puzzles archive title Align puzzles archive page title and game title typography with design Oct 23, 2026
@andresilva-guardian
andresilva-guardian marked this pull request as ready for review October 23, 2026 16:14
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@andresilva-guardian andresilva-guardian self-assigned this Oct 23, 2026
@andresilva-guardian andresilva-guardian added run_chromatic Runs chromatic when label is applied feature Departmental tracking: work on a new feature labels Oct 23, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Oct 23, 2026
@andresilva-guardian
andresilva-guardian added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit e34f5c3 Oct 23, 2026
39 of 46 checks passed
@andresilva-guardian
andresilva-guardian deleted the afs/fix/puzzles-archive-title branch October 23, 2026 16:32
@gu-prout

gu-prout Bot commented Oct 23, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @andresilva-guardian 5 minutes and 6 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants