Repository navigation
Align puzzles archive page typography, colours and spacing with design - #17023
Open
andresilva-guardian wants to merge 10 commits into
Open
andresilva-guardian wants to merge 10 commits into
andresilva-guardian wants to merge 10 commits into
Conversation
Apply headlineBold28 styling to puzzle archive headings at the tablet breakpoint and above.
Add a supporting text theme variable and use it for the archive introduction, giving it a lighter colour in light mode while preserving its dark-mode colour.
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:54c4f6e10ee2a7bbefac21349a56a129075e04a5feea678320ee0b61c7c89f4e"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-afs-fix-puzzles-archive-colors-and-copy"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32923"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGEFrom guardian/actions-ecr. |
…hub.com/guardian/dotcom-rendering into afs/fix/puzzles-archive-colors-and-copy
andresilva-guardian
marked this pull request as ready for review
October 23, 2026 16:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Aligns the puzzles archive page with the latest design QA tickets:
Headings
h1):headline.bld.24below 740px,headline.bld.28from tablet up (washeadline.bld.34everywhere).h2, for example "Mini crossword"):headline.med.28below 740px,headline.med.34from tablet up (washeadline.bld.34). Theline-height: 1.05override is removed so the token's 1.15 applies.Supporting copy under the page title
neutral.46(#707070) in light mode, through a new--puzzles-supporting-text-colourvariable. Dark mode keeps the previous colour.Calendar
Only existing
@guardian/source/foundationstokens are used, so there are no shared library changes.Why?
Design QA tickets for the archive page:
headline.med.34, currentlyheadline.bld.34(tablet to wide)headline.med.28, currentlyheadline.bld.34(mobile to phablet)neutral.46(#707070)The design does not specify the tablet size of the game title, so it follows the desktop value, as the page title does.
How has this change been tested?
PuzzlesArchiveLayoutandPuzzlesArchiveCalendarpass (the layout test now expects the heading "Word games").Layouts/Puzzles Archive)Screenshots