Skip to content

fix(flux): say which chart sources Flux accepts - #127

Merged
guarnz merged 2 commits into
mainfrom
fix/flux-chart-source-kind
Nov 11, 2026
Merged

guarnz merged 2 commits into
mainfrom
fix/flux-chart-source-kind

Conversation

@guarnz

@guarnz guarnz commented Nov 11, 2026

Copy link
Copy Markdown
Owner

What

  • A HelmRelease whose chart.spec.sourceRef is an OCIRepository now fails with an error that says Flux does not accept that kind there and that the OCIRepository goes in spec.chartRef. Any other kind Flux rejects names the kinds it accepts.
  • Chart sources Flux accepts and deadvalues does not read yet, a Bucket in sourceRef and an ExternalArtifact in chartRef, are listed as not supported yet instead of failing.
  • docs/argo-flux.md, docs/output.md and DESIGN.md list both cases.

Why

The error said sourceRef kind "OCIRepository" is not supported, which reads like a deadvalues limitation, while the manifest is the problem: the HelmRelease CRD only takes HelmRepository, GitRepository or Bucket there. For valid sources that are not read yet, an error also failed CI with --fail-on-error, unlike the other sources not supported yet.

Type

  • Bug fix
  • Feature
  • Refactor
  • Build or CI
  • Docs

Checklist

  • Tests pass (go test ./...)
  • Docs updated (README, docs/, or docs/cli via gendocs)
  • No secrets committed

@github-actions github-actions Bot added flux Flux HelmRelease, Kustomization and substitutions cli Commands and flags bug Something does not work as documented labels Nov 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

@guarnz
guarnz merged commit 00cc1d3 into main Nov 11, 2026
13 checks passed
@guarnz
guarnz deleted the fix/flux-chart-source-kind branch November 11, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something does not work as documented cli Commands and flags flux Flux HelmRelease, Kustomization and substitutions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant