Repository navigation
fix(flux): say which chart sources Flux accepts - #127
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
chart.spec.sourceRefis anOCIRepositorynow fails with an error that says Flux does not accept that kind there and that theOCIRepositorygoes inspec.chartRef. Any other kind Flux rejects names the kinds it accepts.BucketinsourceRefand anExternalArtifactinchartRef, are listed as not supported yet instead of failing.Why
The error said
sourceRef kind "OCIRepository" is not supported, which reads like a deadvalues limitation, while the manifest is the problem: the HelmRelease CRD only takesHelmRepository,GitRepositoryorBucketthere. For valid sources that are not read yet, an error also failed CI with--fail-on-error, unlike the other sources not supported yet.Type
Checklist
go test ./...)docs/, ordocs/clivia gendocs)