Skip to content

fix(probe): keep a key conditional when its removal breaks the render - #130

Merged
guarnz merged 1 commit into
mainfrom
fix/required-key-conditional
Nov 12, 2026
Merged

guarnz merged 1 commit into
mainfrom
fix/required-key-conditional

Conversation

@guarnz

@guarnz guarnz commented Nov 12, 2026

Copy link
Copy Markdown
Owner

What

A key under a disabled toggle is now CONDITIONAL when, with the toggle on, removing it breaks the render. Before, a failed render counted as "no effect", so the key came out DEAD.

Why

With an app-template probe turned off (enabled: false), probes.liveness.spec.httpGet.port was reported DEAD while its siblings (httpGet.path, periodSeconds) were CONDITIONAL. The chart schema requires port whenever httpGet is set, so deleting the key as the report suggested made the chart fail to render.

Type

  • Bug fix
  • Feature
  • Refactor
  • Build or CI
  • Docs

Checklist

  • Tests pass (go test ./...)
  • Docs updated (README, docs/, or docs/cli via gendocs)
  • No secrets committed

@github-actions github-actions Bot added detection How keys are classified (dead, redundant, conditional, diff) bug Something does not work as documented labels Nov 12, 2026
@sonarqubecloud

Copy link
Copy Markdown

@guarnz
guarnz merged commit 86a3c69 into main Nov 12, 2026
13 checks passed
@guarnz
guarnz deleted the fix/required-key-conditional branch November 12, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something does not work as documented detection How keys are classified (dead, redundant, conditional, diff)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant