Repository navigation
Takes service-conventions v0.12.0 - #96
Merged
Merged
Conversation
The owner's word moves guestgraph/service-conventions in `service-conventions.json` from v0.11.0 to v0.12.0. The upstream notes are at https://github.com/guestgraph/service-conventions/releases/tag/v0.12.0. The sync ran twice: the v0.11.0 script does not know the wrapper, so the first run writes the new script and the second the wrapper, which already matched after Maven 3.10.0 was merged here. Verified: the pin's move against the local service-conventions at the release commit, then a second sync, `./mvnw -B verify`, `sh service-conventions/regen-er && git diff --exit-code docs/er-schema.mmd`, `sh service-conventions/service-conventions-sync check`, `sh service-conventions/service-conventions-check` and `sh service-conventions/regen-api && git diff --exit-code src/main/resources/api/openapi.yaml` passed. Process: Delivery Phase: Implement Track: Code Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves guestgraph/service-conventions in
service-conventions.jsonfrom v0.11.0 to v0.12.0, on the owner's word. The upstream notes are at https://github.com/guestgraph/service-conventions/releases/tag/v0.12.0: archunit 1.5.1 and spotless 3.10.3 in the parent, the Maven wrapper vendored, and the vendored Dependabot file ignoring the wrapper's Maven and the workflow's actions.The sync ran twice, because the v0.11.0 script does not know the wrapper: the first run writes the new script and the second the wrapper, which already matched since Maven 3.10.0 was merged here.
The
service-conventionsjob fetches the vendored files at the tag, so it stays red until v0.12.0 is published and is re-run then.Verified: the pin's move against the local service-conventions at the release commit, then a second sync,
./mvnw -B verify,regen-erwith no diff,service-conventions-sync check,service-conventions-checkandregen-apiwith no diff passed.🤖 Generated with Claude Code