React usage check: improve bundle detection - #1
Merged
gunjanjaswal merged 1 commit intoSep 21, 2026
Merged
gunjanjaswal merged 1 commit into
gunjanjaswal merged 1 commit into
Conversation
Owner
|
Merged, thank you — this is a real step up from what I had. The per-package detection is the right call; lumping react-dom in with jsx-runtime always undersold how much worse an inlined DOM renderer is. I also hadn't accounted for the react-is false positive or the React 17 prod build hoisting Symbol.for into a local, so those catches are appreciated, and the dev-build warning is a nice bonus. It's now in WordPress#1380, so it'll ride along there. Thanks for taking the time to build on it rather than just flagging the gap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for PR WordPress#1380 by @gunjanjaswal where I implement a more granular check: detect which exact library,
react/jsx-runtime,reactorreact-dom, is inlined. Different libraries have different consequences and severity. Inlining the React JSX Runtime is not a big issue today, because Gutenberg ships a patched React 19 can work with it, but inlining the actual React DOM renderer is much more serious: can lead to crashes that have no workaround.