fix(portal): self-recover stale tabs on any chunk load failure, offer reload on the 500 page - #11
Merged
Merged
Conversation
…load on the error page
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stale tabs/PWAs that lazy-load a content-hashed chunk deleted by a deploy could get stuck on the 500
ErrorPage:vite:preloadErroronly fires for imports that go through Vite's preload helper, and the existing buttons (navigate(-1)/navigate("/")) never fetch a fresh shell. Code-only; no infra changes.stale-chunk-reload.ts:isChunkLoadError(message)matches/failed to fetch dynamically imported module/i,/error loading dynamically imported module/i,/importing a module script failed/i,/chunkloaderror/i.reloadOnce()factors out theRELOAD_STAMP_KEY/RELOAD_COOLDOWN_MS(10s, sessionStorage) guard +window.location.reload().installStaleChunkReload()now wires three triggers throughreloadOnce():vite:preloadError(unchanged,preventDefaultfirst), plusunhandledrejectionanderrorlisteners that fire only whenisChunkLoadErrormatches the reason / error message. Shared cooldown prevents reload loops if the fresh build also fails.ErrorPage.tsx: when the 500detailmatchesisChunkLoadError, render a primary "A new version is available — reload" button callingwindow.location.reload()above the existing back/home buttons.Verified:
npm run lint,npm run format:check,npm run buildinclient/portal.Link to Devin session: https://app.devin.ai/sessions/1348deb2b5ac4efb99688d4995a51f47
Open in Devin Desktop: https://app.devin.ai/desktop/session/1348deb2b5ac4efb99688d4995a51f47?variant=devin
Requested by: @balebbae