fix(css): improve light-mode comment and callout contrast - #91
Merged
Merged
Conversation
hakula139
added a commit
to hakula139/hakula.xyz-kiln
that referenced
this pull request
Oct 1, 2026
) ## Summary - Pin IgnIt `24d7624` from [IgnIt #91](hakula139/IgnIt#91) and regenerate the committed stylesheet. Twikoo placeholders, comment metadata, footer, sorting, and action controls use the existing theme tokens. Callout titles use darker light-mode colors, and author / custom badges use readable semantic colors on opaque theme-tinted surfaces. Validation messages and invalid-input borders use the danger palette. Comment CSS is grouped by responsibility and redundant comments across the theme stylesheets and print selectors are removed. - Use the adaptive secondary-text token for muted age ratings, approximate external scores, and the matching AVG rating legend. Their previous light gray had about 2.54:1 contrast on the white score table. - IgnIt #91 is merged. This site pins its merged commit, whose tree matches the browser-verified theme version. ## Verification - `pnpm build`, `pnpm format`, `pnpm lint`, `pnpm spellcheck`, `nix flake check`, commit / push hooks, and `git diff --check` passed. The comment-only cleanup rebuilt both stylesheets byte-for-byte identically. Current theme and site main are integrated so the submodule pin preserves already-merged heading / mobile TOC changes. [Automatic CI](https://github.com/hakula139/hakula.xyz-kiln/actions/runs/36844759795) and [preview deployment](https://github.com/hakula139/hakula.xyz-kiln/actions/runs/36844759510) passed on final commit `fb1069b`. The minified kiln build rendered and indexed 75 pages. - Headless Chromium audited 56 generated-page / theme / viewport combinations at 1440px and 390px, covering navigation, home cards, archives, taxonomies, profile, links, guestbook, representative articles, code, math, tables, callouts, and 404. No horizontal overflow was observed. - Desktop and mobile interaction checks covered light → dark → light, placeholders, metadata, input focus, enabled / disabled send states, local preview, emote popup, and search results. The final icon correction is checked on visible reaction SVGs and their hover states. Theme CSS loads before Twikoo's injected styles. - Muted score-table text measures 5.34:1 contrast in light mode and 4.84:1 in dark mode. These measurements apply to that table. The existing global link palette is unchanged. - All four supported badge colors exceed 5:1 contrast in both themes. Printing from light or dark mode resolves the light palette. The [hosted preview](https://pr-87-hakula-xyz-kiln.hakula.workers.dev/posts/tutorial/lr2/) serves `fb1069b`. Direct preview checks repeated the desktop/mobile light → dark → light interactions, all badge variants, validation states, search, and printing. The exact LR2 article also shows the corrected badge in light and dark mode. No browser asset replacement or submissions were used. Other browser engines, incompatible Nix systems, and a production deployment were not tested. - Production browsing was read-only. No comments, reactions, uploads, production deployments, or merges were performed. ## Related PR - [Theme implementation](hakula139/IgnIt#91)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!importantso printing while dark mode is active still resolves the light palette, following the existing token contract.Verification
pnpm build,pnpm format,pnpm lint,pnpm spellcheck,nix flake check, andgit diff --checkpassed.