feat(session): re-land the Jev confidence-gated middle layer (#1311) - #1528
Open
aarontrowbridge wants to merge 7 commits into
Open
aarontrowbridge wants to merge 7 commits into
aarontrowbridge wants to merge 7 commits into
Conversation
aarontrowbridge
marked this pull request as draft
September 24, 2026 06:12
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aarontrowbridge
marked this pull request as ready for review
September 25, 2026 11:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1311 — re-land of closed-as-stale-base #1339 (which superseded nothing functionally: same 6-commit slice, replayed fresh off current main per the #1465 slice doctrine).
What
$AMICO_TYPESAFE_KEY_FILE→ amico secrets path~/.amico/typesafe/key), one JSON decision-record receipt per call (primitive, verdict, confidence, latency, model version) in the shared receipts journal. Confirmed wire contract, verified live against the vendor API on the preserved branch (state top-level; questions = type + instructions + criteria; choice criteria = option→rubric map).AMICO_JEV_DISABLED=1disables the path with zero behavioral delta; the bundle test harness injects it by default to stay hermetic.Re-land notes
amico/1301-s5-jev-middlecherry-picked onto currentmain(244e6a9c): zero conflicts;amicode_context.tsauto-merged keeping BOTH fixes (main's Harmoniqs transportapplyHarmoniqsHeaders+ the branch's thread-Noul wiring — both verified present).Verification (this re-land, from package dirs only)
Baseline honesty: the closed PR's "1754/0" was against the Sep-20 base; current
maincarries environment-dependent pre-existing failures, so a clean origin/main baseline worktree was run side-by-side.bun testinpackages/amico-run: 1744 pass / 10 skip / 10 fail across 106 files — the 10 fails are the identical test set (byte-for-byte, timing aside) as a cleanorigin/mainbaseline run: 1698 pass / 9 skip / 10 fail across 102 files. Delta vs baseline: +46 pass, +4 files, +1 skip, failure set unchanged — none of the fails touch the Jev/sessions surface (they are: amico cloud unreachable-endpoint ×2, curlSotaFetch transport ×4, loadRegistry seed bootstrap, parseDoctorArgs, reviewSpec no-real-model-calls guard, gh shim recursion guard).bun test test/jev_client.test.ts test/jev_curation.test.ts test/jev_calibration.test.ts test/sessions_verb.test.ts test/s31.test.tsinpackages/amico-run: 77 pass / 0 fail across 5 files.bun typecheckinpackages/amico-run: 0 errors (tsc --noEmitclean).bun typecheckinpackages/extension: 0 errors (tsc --noEmitclean).bun test test/open_threads.test.tsinpackages/extension: 57 pass / 1 fail across 58 tests (baseline: 47 pass / 1 fail across 48) — +10 new tests, all passing; the 1 fail ("returns null when bun:sqlite is unavailable (Node runtime)") is the identical pre-existingorigin/mainfailure, same class as the documented pre-existing extension set on the feat(amico-run): the strategy-brief renderer — living-sota slice 6 finally lands (portfolio fold, health stamps, one renderer two paths) #1310 re-land.Notes
test/slow/jev_calibration.test.ts) is opt-in by design and was not re-run here — its live verdicts are the director-verified record carried from feat(session): Jev confidence-gated middle layer (classifier residual + onset thread-Noul) #1339; the hermetic battery over the recorded 2026-09-20 fixture is what runs in CI.