feat(packs): re-land the pack lint + the EE/sensing domain packs (#1328) - #1529
Open
aarontrowbridge wants to merge 1 commit into
Open
aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
…measurement and sensing/metrology 'Seeded' means something now (plan-20260920 step 10): - The pack schema gains the domain keys (additive, optional at the schema layer so the flagship stays valid): curricula, payload_schemas, verification (contract reference + claim-class bindings), instruments (with the coverage scope bound), benchmarks, first_task (with the shakedown/substrate level ladder). scores minItems relaxed deliberately: a seeded domain pack legitimately carries no composed scores yet — the quantum-era single-pack contract, not the general one (test updated to the new contract, reason inline). - The pack lint: schema validation PLUS reference resolution (dangling refs = named findings) PLUS the seeded-key check — the flagship reads FORMALIZED (missing first_task), exactly the grandfathered design, and its snapshot-layout skill paths surface as the known real finding the step-14 formalization must reconcile (baked into the test so the reconciliation cannot land silently). - The two seeded packs, each with a verification contract (tier assignments, claim-class bindings), the payloads doc, the first-task declaration (shakedown-marked, NOT yet run — exercised is a run state, never a manifest state), a curriculum skeleton authored to be filled from measured practice, and corrector integrity manifests (load-time shas, the #369 pattern — found by running the loader). Verified: pack_lint 4/4 (EE + sensing seeded; flagship formalized with the known finding); scores suite 323/323; schema 284/284; packaging + gate_packs 65 passed. Loader loads all three packs clean (errors: []). Part of amicode #1328 (plan-20260920-general-research-engine step 10).
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of amicode #1328. Plan-20260920 step 10 re-landed fresh off current main — supersedes #1329 (closed stale-base per the #1465 doctrine; branch
1328-domain-packspreserved).What lands (byte-identical replay of
ab1260fbonto main244e6a9c)Zero conflicts — main's Fleet Studio reshaping (09-23/24) touched none of this slice's paths (
packages/schema,packages/extension/src/scores,packages/extension/packs).curricula,payload_schemas,verification(contract reference with claim-class bindings),instruments(each entry carrying its coverage scope bound — modeled / modeled-at-first-task / unmodeled-until-hardware),benchmarks,first_task(the shakedown | substrate level ladder).scoresminItems relaxed deliberately: a seeded domain pack legitimately carries no composed scores yet — the quantum-era single-pack contract, not the general one.Verified (from package dirs only; mirrors the #1329 record verbatim)
packages/schema:bun run test— 284/284 passed (20 files)packages/extension:bunx vitest run test/pack_lint.test.ts test/packaging.test.ts test/gate_packs.test.ts— pack_lint 4/4; packaging 3 passed (+4 skipped); gate_packs 58 — 65 passed | 4 skipped total; EE + sensing lintseeded: true, the flagship formalized with the known finding classpackages/extension:bunx vitest run test/scores— 323/323 passed (20 files); includes the bundled-packs loader checkloadPacks([packs]).errors === [](all three packs load clean)bun run typecheck— clean in bothpackages/schemaandpackages/extensionHonest scope notes
Resolves #1328.