docs(skills): re-land the spec-reviewer + analyze rewire off the dead P-list model (#1326)

[aarontrowbridge]

Re-land of closed-as-stale-base PR #1327 fresh off current main (244e6a9), per the #1465 slice doctrine — replay of preserved branch sweep-tail (cherry-pick 6d3008c2 → 6ed47edc, zero conflicts: no main commit since the Sep-20 merge base touched either file).

Part of #1326 — the amicode tail of the D6 consumer sweep (with the amico-strategy rewrite landing via #1526 and armonissa #105/PR #106's vault half, this closes the enumerated sweep). Supersedes closed #1327.

Two surgical rewrites, plus one sweep-enumeration miss fixed:

• spec-reviewer-prompt (brainstorming) — the conflict criterion checks against the live direction surface (PI-owned INTENT + conventions), not the frozen STRATEGY.md.
• analyze — the trigger becomes when research direction needs informing (D6 routing inline: survey-shaped → hopper triage tag; intent-direction → the proposals surface; agents never edit INTENT); Strategy Suggestions → Direction Suggestions, reading the strategy brief (amico-run strategy-brief).
• amico-schema-check (new, beyond the docs(skills): rewire the spec-reviewer prompt + analyze skill off the dead P-list model #1327 diff) — its escalation step still told agents to "append to STRATEGY ## Agent Suggestions" (the line predates the sweep; it rode in with the library-absorb chore cd94bfae and the sweep's enumeration missed it). Routed to the amicissimo proposals surface per the same D6 rules (agents never edit INTENT).

Verification (verbatim)

• Skills-integrity lint (packages/extension/scripts/skill_drift_lint.mts, Skill-content drift lint harness + CI coverage #586 CLI — the repo's skills lint), run from packages/extension against this branch's skills dir:

  skill-drift-lint: 35 skills checked (structural only)
    structural failures: 0
    claims: 0 verified · 0 drifted · 0 unverifiable
  EXIT=0
  

• Grep-proof, packages/extension/skills/ on this branch:
  • grep -c STRATEGY analyze/SKILL.md brainstorming/spec-reviewer-prompt.md → 0 / 0 (was 2 / 1 on main)
  • full skills-dir grep -rn STRATEGY → only amico-strategy/SKILL.md (4 hits) — that file is re-land slice R1's territory, its rewrite rides PR feat(amico-run): re-land the strategy-brief renderer (living-sota slice 6, #1310) #1526 (cherry-pick 0d84db3f); zero live STRATEGY refs remain in every other skill
  • grep -rni "p-list\|P1-P11\|plist" → 1 hit (the amico-strategy P1-P11 structure line, R1's file)
• Docs/skill-content only (3 .md files, 4 insertions / 4 deletions) — no TS surface touched, so bun typecheck is not applicable to this diff.

Draft → ready: green (lint + grep-proof clean on this branch's territory); #1326 carries hitl — PI review owns the flip judgment.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: db6f71cf-e2dd-4713-b535-856f7234a446

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}