fix(fleet): shard-watch client census goes $HOME-relative under the hub home (#1558) - #1559
Open
aarontrowbridge wants to merge 1 commit into
Open
aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
…ub home (#1558) A linux hub home embedded literally into the remote census command is unreachable-by-construction on every macOS client (ssh relays sqlite3's exit 1, the client reads as unreachable, the watch silently never censuses the one machine with a real fork history). Re-express the remote db path as "$HOME/<suffix>" when it lives under the hub home — the remote shell expands its own home; exotic layouts keep the quoted literal.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1558.
What
The #1306 shard-watch's client census embedded the hub's DB path literally into the remote command, so every client with a different
$HOME(all macOS machines) failedsqlite3remotely and read asunreachable— a warning by design, meaning the watch silently never censused the fleet's one real fork-risk machine (the macbook, #1302, DB actively diverging today).clientCensusCommand(dbPath, hubHome)now re-expresses the path as"$HOME/<suffix>"(double-quoted — remote shell expands its own home, spaces survive) when it lives under the hub home; outside it stays the quoted literal.sshClientCensuspasseshomedir().Verification (run from
packages/amico-run)bun test test/shard_watch.test.ts— 45 pass / 0 fail (3 new command-builder tests: $HOME-relative default, spaces survive, exotic literal stays)bun test(full package) — 1710 pass / 10 skip / 0 failbun typecheck— clean, exit 0Post-merge live check (the AC)
On erlich: re-run
co.harmoniqs.shard-watch.service→ the receipt must showmacbookwith a real census verdict (clean|divergent+ counts), notunreachable. The mini (thin client since 2026-09-20, no local DB) staysunreachable-as-warning by design —AMICO_SHARD_CLIENTS=macbookon the hub drop-in.