Fleet Studio B2b: wire the Enable-control act end-to-end + re-home it over the composer (#1551) - #1562
Open
jeonghun-jj-lee wants to merge 2 commits into
Open
Fleet Studio B2b: wire the Enable-control act end-to-end + re-home it over the composer (#1551)#1562jeonghun-jj-lee wants to merge 2 commits into
jeonghun-jj-lee wants to merge 2 commits into
Conversation
added 2 commits
September 25, 2026 09:37
…lope (#1551) The self-owned enable path (evaluateControlBootstrap / enableSelfOwnedControl) had ZERO live callers — the app posted the bare amicode.fleet.enableControl command, which is not on the bridge allowlist and has no registered command, so the envelope was dropped. Wire it as a PAYLOAD envelope (the bare command lane cannot carry the target peer): - app: postAmicodeFleetEnableControl posts { source, kind: fleet-enable-control, ownerMachineId, sessionID }. - chat_bridge: BridgeIo.onFleetEnableControl + a shape-validated fleet-enable-control kind handler (NOT added to the command allowlist). - fleet_control_bootstrap: handleEnableControlRequest — the live decision path (confirm-first native modal, then establishManagementVerified + enableSelfOwnedControl). Cancel / shared / unverified mint nothing. - chat_panel: static onFleetEnableControl callback, threaded into the bridge IO, + fleet-enable-control added to both outer-relay inbound allowlists. - extension: wire ChatPanel.onFleetEnableControl at activation to the live fleet-peer provider + enroll-seeded authority resolver + grant store, with the ADR 0034 D4 native-modal confirm. Grant persistence flips the projection on the next poll — the app never self-declares interactive.
…1551) DEFECT 2 — the affordance rendered as a fixed top-right Portal over the titlebar. Remove that placement and re-home it onto a composer-anchored scrim: - session-header: remove the top-right fixed Portal + ENABLE_CONTROL_COMMAND; add SessionComposerControlScrim, which BLURS + gates (inert → non-editable) the composer and centers a 'This session lives on <peer> — Enable control to drive it' CTA when the current session is a REMOTE peer and control is NOT held. When control is held (interactive) or the session is local/unowned, the composer renders untouched (no scrim). The CTA posts DEFECT 1's payload envelope (postAmicodeFleetEnableControl). - session-fleet-peers: findSessionOwnerInProjection — the scrim's source for the peer name (CTA copy) + owner machineId (envelope target). - session.tsx: wrap the composer (PromptInputV2Composer / PromptInput) with the scrim. - session-header.test: replace the top-right-Portal assertions with the composer-scrim + gated-composer assertions. The sidebar-fleet #1544 AC5 regression guard stays green (no control markers leak into the read-only sidebar).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1551. Base:
feature/free-tier-fleet.The last mile of B2b, surfaced by live verification after #1547 merged: on a self-owned remote peer-studio session, Enable control was a no-op and sat over the titlebar. This wires the act and re-homes the affordance.
What was broken
amicode.fleet.enableControl, but that command was not on the bridge allowlist and no extension command handled it;enableSelfOwnedControl/evaluateControlBootstraphad zero live callers. Fleet Studio B2b · slice 4 — Control UI: enable, driving banner, fail-closed affordances #1544 shipped the state channel and Fleet Studio B2b · slice 2 — Observation write plane: control-gated remote writes #1542 the write plane, but the act that mints the grant was never connected.What this does
fleet-enable-controlbridge envelope ({ ownerMachineId, sessionID }— the bare command lane can't carry a target) → a new vscode-freehandleEnableControlRequest(confirm-first) composingestablishManagementVerified+enableSelfOwnedControl. Activation wires the ADR-0034-D4 native modal + the live fleet-peer provider / enroll-seeded authority / grant store. Grant persistence flips the projection: the next/amicode/fleet/sessionspoll re-resolvesamicode_controltointeractiveand lights the driving banner — the app never self-declares interactive (SoT stays the source).SessionComposerControlScrimwraps the composer slot insession.tsx: while a remote peer session's control is not held, the composer is blurred +inert(non-editable) and a centered CTA ("This session lives on<peer>— Enable control to drive it") posts the DEFECT-1 envelope. Held/local → no scrim.Invariants held
BRIDGE_ALLOWED_COMMANDSuntouched; new payloadkindadded beside it).Gates (director-independent re-run on this branch)
Deploy + verify (for JJ)