Update the importance of hostname on guest cluster - #1140
Open
w13915984028 wants to merge 1 commit into
Open
w13915984028 wants to merge 1 commit into
w13915984028 wants to merge 1 commit into
Conversation
w13915984028
requested review from
a team and
jillian-maroket
as code owners
September 21, 2026 20:04
|
w13915984028
force-pushed
the
doc11682-hostname-limits
branch
from
September 21, 2026 20:26
51439c6 to
f7bcccc
Compare
5 of 27 tasks
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fix the incorrect internal anchors in both cloud-provider documents.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Updates Rancher guest-cluster documentation to discourage static hostnames and explain related provisioning risks.
Changes:
- Adds hostname guidance to RKE2 and K3s documentation.
- Adds hostname risks and custom-cluster notes to cloud-provider documentation.
- Updates related links and image paths.
| File | Summary |
|---|---|
versioned_docs/version-v1.9/rancher/node/rke2-cluster.md |
Adds versioned hostname guidance. |
versioned_docs/version-v1.9/rancher/node/k3s-cluster.md |
Adds versioned hostname guidance. |
versioned_docs/version-v1.9/rancher/cloud-provider.md |
Adds versioned hostname documentation. |
docs/rancher/node/rke2-cluster.md |
Adds hostname guidance. |
docs/rancher/node/k3s-cluster.md |
Adds hostname guidance. |
docs/rancher/cloud-provider.md |
Adds hostname guidance and related updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Jian Wang <jian.wang@suse.com>
w13915984028
force-pushed
the
doc11682-hostname-limits
branch
from
September 21, 2026 20:44
f7bcccc to
23a76f8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The hardcoded hostname could cause many issues on guest cluster provision.
Solution:
Update the importance of hostname on guest cluster
Related Issue(s):
harvester/harvester#11682
Test plan:
Additional documentation or context