Conversation
Owner
|
I'm not available right now to fully review the changes, but I can do a better review once I'm back |
- Replace vendored Clipper 6.4.2 with Clipper2 2.0.1 submodule - Rewrite clipper_tools.cpp: ClipperLib → Clipper2Lib types and API - Bump C++ standard from cxx_std_11 to cxx_std_17 - Update include paths and object library references - Bump version to 1.0.1-pre
nsluhrs
force-pushed
the
clipper2-migration
branch
from
July 27, 2026 19:13
69e3f89 to
18725ca
Compare
Author
|
Looking. At clipper tools 252 do we want the square or bevel miter type? The original was square rather than miter |
nsluhrs
marked this pull request as ready for review
July 27, 2026 19:47
Author
|
I think the test workflow would also need to be changed for this as the runner doesn't seem to grab the submodle |
Owner
I think we should maintain the default for backwards compatibility. |
…ith older versions
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, AI assisted, specifically opencode.
I am interested in moving to Clipper2 as I've run into some very large problems at work that I'd like to see performance improvements in.
I am still making sure everything is working okay, but preliminary tests are pretty promising, not seeing that big of speedups for small test cases but I do start to see fairly significant gains for larger test cases, though not in all cases. I can add some comparisons to this later if that would be helpful.
A few things I was concerned about:
Code style concerns particularly the
usingstatements.I wasn't sure if it would be better to have a vendored copy of Clipper2 in the code base directly instead of having a submodule as I know those are often not the best fit. I had considered it but I also wasn't sure which version would be best to include and figured a submodule would be easier to swap between versions.