feat: remove datacenter property from server and primary_ip#1449
Draft
lukasmetzner wants to merge 3 commits into
Draft
feat: remove datacenter property from server and primary_ip#1449lukasmetzner wants to merge 3 commits into
lukasmetzner wants to merge 3 commits into
Conversation
Contributor
Author
|
Needs hetznercloud/hcloud-go#890 and rebase |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
===========================================
- Coverage 72.86% 51.49% -21.38%
===========================================
Files 300 295 -5
Lines 11124 10838 -286
===========================================
- Hits 8106 5581 -2525
- Misses 2119 4710 +2591
+ Partials 899 547 -352
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
datacenterproperty from Server and Primary IP resource where possible. The property was deprecated ~6 months ago, and because the property is removed from the API, removing it from our code is not considered a breaking change.