Check release prerequisites before changing the VSCode changelog - #360
Merged
Merged
Conversation
|
highbyte
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VS Code release helper could rewrite the changelog and then fail during its commit because pre-commit needed a Python version that was not installed. It now checks required tools and GitHub access, verifies the installed hook's configured Python versions, and prepares hook environments before changing the changelog.
--check-toolsruns the same preflight without starting a release.Validated with
bash -n,release.sh --check-tools, and 22 isolated success/failure checks covering missing Python, hook setup, GitHub access, and startup ordering. The repository's pre-commit hook was also run for the changed files (no matching docs-requirements files to check).