Fix browser dialog actions and desktop zoom behavior - #363
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser zoom wrapper reparented MainView during startup, removing its view-model subscriptions and leaving Settings, About, Load snap, and Save snap unresponsive. Restore subscriptions when the view reattaches and clean up handlers consistently to prevent duplicates.
Keep mouse-first desktop browsers at 100% app zoom with the toolbar hidden, while preserving scrolling and panning when content overflows. Touch-first devices retain Fit and zoom controls, including updates when the primary pointer changes.
Validation: all six browser script checks pass; browser build passed; the user verified both changes on localhost:5000. Automated live UI verification was blocked by accessibility tooling. The preview publish also reported existing trimming warnings.