grid/api-generator - #26
Merged
Merged
Conversation
Keep Column id, Header options, and the options JSON prop. Restore Links to Grid.Options.* on the new props. Co-authored-by: Cursor <cursoragent@cursor.com>
Parse `(props: T) => null` from dist .d.ts so option components keep their props after the new options/id API, and lock the contract with tests. Co-authored-by: Cursor <cursoragent@cursor.com>
sebastianbochan
changed the base branch from
grid/new-api-components
to
grid/jsx-components
September 9, 2026 08:44
KamilKubik
requested changes
Sep 21, 2026
KamilKubik
left a comment
KamilKubik
left a comment
Collaborator
There was a problem hiding this comment.
Nice!
Some thoughts:
Grid.Gridlooks a bit off, is this intendent? Are you planning on including more components underGrid?
- I'm a bit confused when it comes to
Grid.options, and generally all the components carrying theoptionsprop. So, on the one hand, I understand we don't nest those options under it in the API as the nesting tree ends up onoptions, which is a prop (maybe we should?). However, it points me toTOptions, which is defined as a class, and says nothing about the options I can use. In Highcharts React, I added that extra nesting in the navigation for those options, which I'm starting to think is wrong, but I don't think it's defined anywhere else, since it's integration-specific. Any thoughts? I think the overall goal should be to easily allow users to be able to look into all available options, without breaking the navigation semantically.
KamilKubik
self-requested a review
September 21, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tree api generator.