Repository navigation
Supersede Dependabot #2: Newtonsoft.Json 13 no longer applies - #15
Merged
Merged
Conversation
Newtonsoft.Json 10.0.2 existed only in the removed packages.config project, so the 13.0.2 bump cannot be applied on the SDK-style tree. Group NuGet updates for the current solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request supersedes #2 (Bump Newtonsoft.Json from 10.0.2 to 13.0.2 in
/AzCopyAndDelete/AzCopyAndDelete).#2 updates
AzCopyAndDelete/AzCopyAndDelete/packages.configand conflicts withmaster. That manifest, the committedpackages/Newtonsoft.Json.10.0.2tree, and the .NET Framework project that referenced it were removed when the app moved to SDK-style projects on .NET 8 andAzure.Storage.Blobs. Application code never called Newtonsoft.Json directly; the package was pulled in by the legacy Storage SDK.The current restore graph has no Newtonsoft.Json reference (direct or transitive).
dotnet list AzCopyAndDelete.sln package --vulnerable --include-transitivereports no vulnerable packages, so there is no 13.0.2 package bump to apply on this tree. #2 is left open and is not merged.NuGet updates in Dependabot are now grouped (
groups.nugetwith pattern*) so later package bumps open as one pull request instead of one PR per package.Test plan
dotnet format AzCopyAndDelete.sln --verify-no-changesdotnet build AzCopyAndDelete.sln -c Releasedotnet test AzCopyAndDelete.sln -c Release(16 passed)dotnet listpackage graph contains noNewtonsoft.Json