Skip to content

fix: Codex linked worktree の Git metadata 操作を Auto-review 対応する - #65

Merged
hirokisakabe merged 4 commits into
mainfrom
codex-linked-worktree-auto-review-64
Sep 25, 2026
Merged

hirokisakabe merged 4 commits into
mainfrom
codex-linked-worktree-auto-review-64

Conversation

@hirokisakabe

@hirokisakabe hirokisakabe commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

close #64

目的

Codex CLI の managed linked worktree で共有 Git metadata が workspace-write から read-only になる場合でも、sandbox 境界を維持したまま Auto-review の narrowly scoped escalation を利用して実装フローを完遂できるようにします。

変更内容

  • skills/issue-dispatch/SKILL.md
    • worker を codex exec --approve-for-me --worktree で起動
    • --worktree / --approve-for-me の preflight を追加
    • Git metadata mutation の exact-command escalation、blocked 条件、検証証跡を定義
  • skills/issue-implement/SKILL.md
    • branch 確立前の fetch / switch と、その後の add / commit / push を個別の scoped escalation として定義
    • Auto-review unavailable / denied / timeout と metadata write failure の blocker 記録を定義
  • skills/worktree-start/SKILL.md
    • Codex CLI worker の起動契約を同期
    • changed skill の version consistency workflow に合わせて 3.1.0 へ alignment
  • AGENTS.md / README.md
    • --approve-for-me が worker を workspace-write で動かし、sandbox 境界越えの approval request を Auto-review に送る契約へ同期

ローカル検証

  • git diff --check
  • git diff --check origin/main...HEAD
  • 旧 codex exec --worktree、-a never、明示的な --sandbox workspace-write の不整合検索
  • --worktree / --approve-for-me preflight、exact-command escalation、blocked 条件、禁止 fallback、検証証跡規則の静的契約検証
  • .github/workflows/pr-version-check.yml と同じ比較ロジックで、変更された issue-dispatch / issue-implement / worktree-start がすべて 3.1.0 であることを確認
  • CLAUDE.md が AGENTS.md への symlink のままであることを確認
  • issue fix: Codex linked worktree の Git metadata 制約を Auto-review で安全に回避する #64 の受け入れ条件: 10/10 PASS

Cross-review

  • 親セッションの独立 final cross-review: critical 0 / warning 0
  • レビュー修正は amend / rebase を使わず追加 commit として記録

成功経路の検証証跡

  • 実行条件: Codex managed linked worktree、workspace-write、Auto-review 有効、issue fix: Codex linked worktree の Git metadata 制約を Auto-review で安全に回避する #64 専用 branch
  • exact Git commands:
    • git fetch origin main
    • git switch -c codex-linked-worktree-auto-review-64 origin/main
    • git add skills/issue-dispatch/SKILL.md skills/issue-implement/SKILL.md
    • git commit -m "fix: route linked-worktree git mutations through auto-review"
    • git add AGENTS.md README.md skills/issue-dispatch/SKILL.md skills/issue-implement/SKILL.md
    • git commit -m "docs: align auto-review workflow contract"
    • git add AGENTS.md README.md skills/worktree-start/SKILL.md
    • git commit -m "docs: clarify approve-for-me sandbox contract"
    • git push -u origin codex-linked-worktree-auto-review-64
    • git add skills/worktree-start/SKILL.md
    • git commit -m "chore: align changed skill versions"
    • git push -u origin codex-linked-worktree-auto-review-64
  • Auto-review 判定: 上記 Git metadata mutation はすべて scoped escalation として承認
  • worker state: succeeded
  • branch: codex-linked-worktree-auto-review-64
  • PR: fix: Codex linked worktree の Git metadata 操作を Auto-review 対応する #65
  • CI: Skill Version Consistency Check success(https://github.com/hirokisakabe/issuekit/actions/runs/36135319375)
  • blocker: なし

失敗経路の検証証跡

  • 実行条件: 実装前の disposable Codex managed linked worktree で、共有 Git metadata が通常の workspace-write sandbox から read-only
  • 対象 Git command: git switch -c <expected-branch> origin/<default-branch>(検証用 branch 名をプレースホルダー化)
  • 結果: 通常 sandbox 実行では index.lock: Operation not permitted となることを確認
  • Auto-review 判定: 通常実行のため approval request は生成されず、成功扱いにしない
  • worker state: blocked
  • PR / CI: not-run
  • blocker: Git metadata write failure。権限拡大、writable-root 追加、--add-dir、alternate Git directory、手動 worktree fallback は適用せず停止

@hirokisakabe
hirokisakabe merged commit 765e60c into main Sep 25, 2026
1 check passed
@hirokisakabe
hirokisakabe deleted the codex-linked-worktree-auto-review-64 branch September 25, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Codex linked worktree の Git metadata 制約を Auto-review で安全に回避する

1 participant