fix: Codex linked worktree の Git metadata 操作を Auto-review 対応する - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #64
目的
Codex CLI の managed linked worktree で共有 Git metadata が
workspace-writeから read-only になる場合でも、sandbox 境界を維持したまま Auto-review の narrowly scoped escalation を利用して実装フローを完遂できるようにします。変更内容
skills/issue-dispatch/SKILL.mdcodex exec --approve-for-me --worktreeで起動--worktree/--approve-for-meの preflight を追加skills/issue-implement/SKILL.mdfetch/switchと、その後のadd/commit/pushを個別の scoped escalation として定義skills/worktree-start/SKILL.md3.1.0へ alignmentAGENTS.md/README.md--approve-for-meが worker をworkspace-writeで動かし、sandbox 境界越えの approval request を Auto-review に送る契約へ同期ローカル検証
git diff --checkgit diff --check origin/main...HEADcodex exec --worktree、-a never、明示的な--sandbox workspace-writeの不整合検索--worktree/--approve-for-mepreflight、exact-command escalation、blocked 条件、禁止 fallback、検証証跡規則の静的契約検証.github/workflows/pr-version-check.ymlと同じ比較ロジックで、変更されたissue-dispatch/issue-implement/worktree-startがすべて3.1.0であることを確認CLAUDE.mdがAGENTS.mdへの symlink のままであることを確認Cross-review
成功経路の検証証跡
workspace-write、Auto-review 有効、issue fix: Codex linked worktree の Git metadata 制約を Auto-review で安全に回避する #64 専用 branchgit fetch origin maingit switch -c codex-linked-worktree-auto-review-64 origin/maingit add skills/issue-dispatch/SKILL.md skills/issue-implement/SKILL.mdgit commit -m "fix: route linked-worktree git mutations through auto-review"git add AGENTS.md README.md skills/issue-dispatch/SKILL.md skills/issue-implement/SKILL.mdgit commit -m "docs: align auto-review workflow contract"git add AGENTS.md README.md skills/worktree-start/SKILL.mdgit commit -m "docs: clarify approve-for-me sandbox contract"git push -u origin codex-linked-worktree-auto-review-64git add skills/worktree-start/SKILL.mdgit commit -m "chore: align changed skill versions"git push -u origin codex-linked-worktree-auto-review-64codex-linked-worktree-auto-review-64Skill Version Consistency Checksuccess(https://github.com/hirokisakabe/issuekit/actions/runs/36135319375)失敗経路の検証証跡
workspace-writesandbox から read-onlygit switch -c <expected-branch> origin/<default-branch>(検証用 branch 名をプレースホルダー化)index.lock: Operation not permittedとなることを確認--add-dir、alternate Git directory、手動 worktree fallback は適用せず停止