Conversation
🦋 Changeset detectedLatest commit: 64ab4ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #369.
Summary
Responseconstructor identity check with an explicit interface check and normalize compatible responses before passing them to the Node.js adapterPonyfillResponsefrom@whatwg-node/node-fetchThis allows Fetch API-compatible implementations such as the response returned by GraphQL Yoga to work without requiring applications to recreate them with Node.js's global
Responseconstructor. Compatible non-native responses are normalized at the adapter boundary so the downstream Node.js response writer receives the body shape it expects.The existing check was introduced in #45 to reject invalid return values such as strings, and #63 later routed those values through Vite's error handler. This change preserves that behavior while validating the runtime interface without a type assertion, so compatible Response implementations are not treated as application errors.
Tests
yarn workspace @hono/vite-dev-server test:unityarn workspace @hono/vite-dev-server buildyarn workspace @hono/vite-dev-server exec playwright test e2e/basic/basic.test.ts --grep "another Fetch API implementation"yarn formatyarn lint