Repository navigation
fix(activesync): tolerate a meeting response without meeting data - #255
Merged
Merged
Conversation
When the ActiveSync mail builder cannot parse an iTip reply it now leaves the message as plain mail and sets no meetingrequest. Driver::getMessage() must not call getvEvent() on a missing meeting request, and getvEvent() may return null for a request that has no event, so skip the attendee import in both cases. Refs horde/ActiveSync#112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getvEvent()on a missing meeting request when importing an incoming iTip reply; skip the attendee import when there is no event.Fixes horde/ActiveSync#112 (together with horde/ActiveSync#113).
Motivation
The ActiveSync mail builder now degrades an unusable iTip reply to a plain message (no
meetingrequest), andMeetingRequest::getvEvent()returnsnullwhen no event was parsed.Horde_Core_ActiveSync_Driver::getMessage()passed the result straight toConnector::calendar_import_attendee(), which is typedHorde_Icalendar_vEvent.Changes
Driver::getMessage(): resolve the vEvent first andbreakif there is none.No new
catchblocks.Test plan
php -l lib/Horde/Core/ActiveSync/Driver.php