Repository navigation
fix(query): carry execution_time_ms through async poll path - #184
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Carries execution_time_ms through the async poll/status paths correctly. Helper mirrors the inline path's negative clamp, null stays None (em dash) rather than a fabricated 0, and both call sites are updated consistently. Tests cover the double-option mapping cases plus a regression integration test for #183. LGTM.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slow queries (>~1s) fall back to async execution, and the Arrow result fetch hardcoded
execution_time_ms: None, sohotdata queryreported null timing for exactly the queries you most want to time. The asyncexecutepoll loop andquery statusnow stamp the run's ownexecution_time_msonto the displayed result.Closes #183