Repository navigation
feat(databases): show created_at in list and show commands - #217
Merged
Merged
Conversation
Adds a CREATED column to `databases list` and a created_at row to `databases show`. Uses the updated SDK models from sdk-rust feat/database-timestamps (PR #909 in runtimedb). Cargo.toml temporarily points to local sdk-rust path; update to published version once sdk-rust feat/database-timestamps is released.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| /// common first command against an idle workspace. | ||
| fn list_database_summaries(api: &Api) -> Result<Vec<DatabaseSummary>, ApiError> { | ||
| block_with_wakeup(api, "Loading databases…", api.client().databases().list()) | ||
| block_with_wakeup(api, "Loading databases...", api.client().databases().list()) |
Contributor
There was a problem hiding this comment.
super nit: this swaps the Unicode ellipsis … for three dots ..., which is unrelated to the created_at feature and introduces inconsistency within this file — other spinners here still use … (e.g. line 1317 "Deleting database…"). Suggest keeping … to match the surrounding code. (not blocking)
|
|
||
| impl From<hotdata::models::DatabaseSummary> for DatabaseSummary { | ||
| /// Map the SDK's typed summary into the CLI's list-row output shape. | ||
| fn from(s: hotdata::models::DatabaseSummary) -> Self { |
Contributor
There was a problem hiding this comment.
super nit: this drops the existing doc comment /// Map the SDK's typed summary into the CLI's list-row output shape. for no apparent reason. The sibling From<DatabaseDetailResponse> impl above still keeps its doc comment, so removing this one makes the two inconsistent. (not blocking)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
eddietejeda
added a commit
that referenced
this pull request
Jul 10, 2026
* feat(databases): show created_at in list and show commands Adds a CREATED column to `databases list` and a created_at row to `databases show`. Uses the updated SDK models from sdk-rust feat/database-timestamps (PR #909 in runtimedb). Cargo.toml temporarily points to local sdk-rust path; update to published version once sdk-rust feat/database-timestamps is released. * chore: update hotdata SDK to v0.8.1 (created_at on databases) --------- Co-authored-by: Eddie A Tejeda <669988+eddietejeda@users.noreply.github.com>
eddietejeda
added a commit
that referenced
this pull request
Jul 10, 2026
* feat(cli): loading indicators for indexes list and usage Both commands sat silent while fetching. `indexes list` gets one spinner over the whole fetch - the unscoped path is a whole-workspace scan (connections enumeration + managed-DB discovery + per-table index reads) that can take seconds. The database discovery inside the scan (databases::list_database_ids) drops its nested "Loading databases..." wakeup spinner so two indicatif bars never fight over the same line; `databases list` itself keeps the wakeup-hint spinner. `usage` gets a plain spinner around its single request. * feat(databases): show created_at in list and show commands (#217) * feat(databases): show created_at in list and show commands Adds a CREATED column to `databases list` and a created_at row to `databases show`. Uses the updated SDK models from sdk-rust feat/database-timestamps (PR #909 in runtimedb). Cargo.toml temporarily points to local sdk-rust path; update to published version once sdk-rust feat/database-timestamps is released. * chore: update hotdata SDK to v0.8.1 (created_at on databases) --------- Co-authored-by: Eddie A Tejeda <669988+eddietejeda@users.noreply.github.com> * feat(ingest): rename the catalog verb connectors -> datasources (#216) 'hotdata ingest datasources' now browses the catalog of available datasource types; 'connectors' stays as a hidden alias. Help, error hints, README, and the skill follow. Co-authored-by: Eddie A Tejeda <669988+eddietejeda@users.noreply.github.com> * fix(indexes): clear spinner before exiting on API error The fetch helpers called e.exit() (process::exit) internally, leaving the indicatif spinner live on the terminal when any API call failed. Convert list_one_table, list_one_table_scan, collect_tables, connection_lookup, managed_db_connection_ids, workspace_scan_targets, and collect_connection_wide to return Result<_, ApiError>, then finish_and_clear() the spinner in list() before unwrap_or_else(|e| e.exit()) -- matching the usage.rs pattern. * style: cargo fmt --------- Co-authored-by: Eddie A Tejeda <669988+eddietejeda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hotdata databases listcreated_at:row tohotdata databases showcreated_attoDatabaseSummaryandDatabaseDetailResponse)Timestamps formatted via the existing
util::format_datehelper. Databases created before runtimedb PR #909 already have real timestamps — the column existed with NOT NULL DEFAULT CURRENT_TIMESTAMP since the table was introduced.Test plan