Repository navigation
Close phase 6 in the roadmap and open phase 7 - #20
Merged
Merged
Conversation
rohan-hotdata
requested review from
shefeek-jinnah
and removed request for
a team
October 14, 2026 09:59
| memory". | ||
|
|
||
| Read from `bench/models.py`, not observed: a reply that reaches the limit raises | ||
| before the cache stores it, and a reply that fails to parse stops the run. So the |
There was a problem hiding this comment.
nit: The note says the cache does not hold a reply that fails to parse. The cache does hold that reply (not blocking).
Fix: "a reply that fails to parse is stored in the cache, but it stops the run. So no completed result file holds either fault, and this task confirms it."
CachedModels.__call__ stores each reply at bench/models.py:76-80 before it returns the reply. json.loads runs later, at bench/e2e.py:160, so a parse failure raises only after the insert. The token-limit case at bench/models.py:137-138 raises inside complete, so the first half of the note is correct. Without the fix, task 2 can look for the wrong thing in the cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes phase 6 in the roadmap and opens phase 7 as issue #19. It changes
docs/internal/roadmap.mdanddocs/internal/plan.mdonly.How
roadmap.md: phase 6 is closed with PR Phase 6: the accuracy loop, with sample B and the diagnosis split #18, and phase 7 is open with issue Phase 7: the extractor #19. Phase 6 gets its closing paragraph, with what it changed for later phases.plan.md: the phase 6 section is removed, because the plan keeps only the open phases. Its full text and decisions stay at commit8a7318d.plan.md: the start table gains the sample B baseline and the split of the recalled group.plan.md: phase 7 names the target on both samples (19 on A, 16 on B), and lists the commands that phase 6 built.plan.md: task 2 of phase 7 gains a note, read from the code and not observed. A reply at the token limit is not stored in the cache. A reply that fails to parse is stored, but it stops the run, so no completed result file holds either fault.Verification
make verifypasses, with the link check.Notes
docs/internal/mem0-survey.mdis not part of this PR.