Repository navigation
ci: set origin/HEAD before running release.sh - #218
Merged
Merged
Conversation
actions/checkout does not create refs/remotes/origin/HEAD, so release.sh's default_branch() resolved to an empty string and the first Cut Release run failed on an empty pathspec.
eddietejeda
requested review from
anoop-narang
and removed request for
a team
October 15, 2026 19:38
eddietejeda
enabled auto-merge (squash)
October 15, 2026 19:38
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| # actions/checkout never sets; without this the script sees an empty | ||
| # branch name and git aborts on an empty pathspec. | ||
| - name: Point origin/HEAD at the default branch | ||
| run: git remote set-head origin --auto |
There was a problem hiding this comment.
nit: Fix the fallback in default_branch() at scripts/release.sh:123-128 too (not blocking). The current fallback cannot recover from a missing origin/HEAD, so any other clone without origin/HEAD fails the same way.
The fallback has two defects:
- The
sedexpression uses|as its delimiter. Inside the pattern,\|therefore matches a literal|, not alternation. Theorigin/mainline never matches. - Under
set -o pipefail, thegit branch -r | sed | headpipeline exits 0 with empty output. The|| echo mainbranch never runs.
One fix: use # as the sed delimiter. Also replace the || chain with an explicit [[ -n "$b" ]] check before the echo main default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first Cut Release run (38795364225) failed in
release.sh preparewithfatal: empty string is not a valid pathspec. The script resolves the base branch fromorigin/HEAD, whichactions/checkoutnever sets. Both jobs now rungit remote set-head origin --autobefore calling the script. No script change.