Skip to content

chore: add 403 forbidden response to endpoints #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotdata-automation merged 1 commit into from
Sep 26, 2026
Merged

chore: add 403 forbidden response to endpoints #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- chore: add 403 forbidden response to endpoints
- feat(jobs): add database_fork job type

## [0.19.0] - 2026-09-23
Expand Down
1 change: 1 addition & 0 deletions src/apis/information_schema_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ use serde::{de::Error as _, Deserialize, Serialize};
#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(untagged)]
pub enum InformationSchemaError {
Status403(models::ApiErrorResponse),
Status404(models::ApiErrorResponse),
UnknownValue(serde_json::Value),
}
Expand Down
1 change: 1 addition & 0 deletions src/apis/jobs_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ use serde::{de::Error as _, Deserialize, Serialize};
#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(untagged)]
pub enum GetJobError {
Status403(models::ApiErrorResponse),

@claude claude Bot Sep 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: A 404 response body now deserializes as GetJobError::Status403 (not blocking).

GetJobError is #[serde(untagged)], so serde returns the first variant that matches. Status403 and Status404 wrap the same type, models::ApiErrorResponse. Line 89 parses the body without checking the HTTP status. Callers that match on Status404 stop matching after this change. The same change applies to InformationSchemaError in src/apis/information_schema_api.rs:20.

Many other error enums in src/apis/ already have this problem, so a fix belongs in the generator template. One option is to select the variant from status instead of relying on untagged deserialization. Another option is to note the variant change in the CHANGELOG entry.

Status404(models::ApiErrorResponse),
UnknownValue(serde_json::Value),
}
Expand Down
Loading